Skip to content

Document and test the configuration option "requestedSecretLifetime" #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2025
Merged

Document and test the configuration option "requestedSecretLifetime" #832

merged 3 commits into from
Mar 12, 2025

Conversation

@siegfriedweber
Copy link
Member

Description

The configuration option requestedSecretLifetime is documented and tested.

This option was added in #796.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber requested a review from a team March 11, 2025 11:59
@siegfriedweber siegfriedweber self-assigned this Mar 11, 2025
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Mar 11, 2025
@adwk67 adwk67 requested review from adwk67 and removed request for a team March 12, 2025 12:26
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 12, 2025
adwk67
adwk67 approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber siegfriedweber added this pull request to the merge queue Mar 12, 2025
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Mar 12, 2025
Merged via the queue into main with commit eb8129b Mar 12, 2025
16 of 17 checks passed
@siegfriedweber siegfriedweber deleted the doc/certificate-lifetime branch March 12, 2025 13:15
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels

area/documentation customer-request release/25.3.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siegfriedweber @adwk67 @lfrancke